[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu May 12 01:14:35 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #25 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-12 08:14:28 UTC ---
* Please don't mix multiple changes in a single patch. Attach one patch for the
dup-property/SET_DUP_COUNT and another one for removing the discont function.

* libtheora will handle the bitrate/keyframe constraints internally already and
will not output more dup frames than allowed

* You should keep a queue with buffer timestamps and durations for the dup
frames and use these values for the output instead of interpolating

* I think your GAP flag handling is wrong. You should always keep the last
non-gap buffer, count the number of gap buffers and on the next non-gap buffer
you encode the previous non-gap buffer, get the dups and then keep the new
non-gap buffer and do everything from the beginning again

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list