[Bug 650470] New: RTP: Some depayloaders break with malformed rtp packets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650470
  GStreamer | gst-plugins-good | git

           Summary: RTP: Some depayloaders break with malformed rtp
                    packets
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: santoscadenas at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=188021)
 View: https://bugzilla.gnome.org/attachment.cgi?id=188021
 Review: https://bugzilla.gnome.org/review?bug=650470&attachment=188021

Patch that solves the described problem

I've found that some depayloaders fall down in a segmentation fault when the
received rtp packet is malformed.

I've tested with PortGo softphone for Windows. The first rtp packet that this
program emits is malformed (according to wireshark). When this packed is
received, the depayload tries to find the payload buffer of the packet but is
not there and the functions gst_rtp_buffer_get_payload_buffer and
gst_rtp_buffer_get_payload_subbuffer return NULL and print this line:

** (GstreamerMediaServer:8057): WARNING **: offset=0 should be less then plen=0

The problem is that some depayloaders do not check if the returned values is
NULL and they try to use it.

I attach a patch that solves the problem for all the depayloaders that didn't
do the check.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.