[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187950|none                        |needs-work
             status|                            |

--- Comment #36 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-18 11:56:11 UTC ---
Review of attachment 187950:
 --> (https://bugzilla.gnome.org/review?bug=627459&attachment=187950)

Did you test that this produces the correct output, as we've discussed it
earlier in this bug?
And do you have any idea how to fix the discont check function?

::: ext/theora/gsttheoraenc.c
@@ +1095,3 @@
+  g_assert (enc->t_queue != NULL);
+
+  ptr = g_malloc (sizeof (GstClockTime));

Oh right, we're talking about guint64 here and can't just store them in the
GQueue. The best might be to implement your own simple ringbuffer on top of an
array then for the queue... or at least use GSlice to allocate the elements.
Sorry

@@ +1343,3 @@
+        theora_timefifo_in (enc, &timestamp);
+        /* We should haveone frame delay to create correct frame order.
+         * First time we got buuffer, prevbuf should be empty. Nothing alse

Typos ;)

@@ +1355,3 @@
+          t_queue_lenght++;
+
+          if (t_queue_lenght > 2) {

and yet another typo, length :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.