[Bug 650416] [h264parse] Assertion failure: nal_size >=2

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650416
  GStreamer | gst-plugins-bad | git

--- Comment #6 from bens at alum.mit.edu 2011-05-18 22:07:37 UTC ---
Created an attachment (id=188084)
 View: https://bugzilla.gnome.org/attachment.cgi?id=188084
 Review: https://bugzilla.gnome.org/review?bug=650416&attachment=188084

Patch to fix the bug as suggested

This patch fixes the bug, AFAICT.  Rather than remove the assertion in
parse_process_nal, it checks it upstream in check_valid_frame.  This makes
sense, I think, because it allows us to return FALSE from check_valid_frame if
the frame is indeed invalid.  It almost looks like the code was designed to
have this check, given the comment above parse_process_nal that "caller
guarantees 2 bytes of nal payload".

Needs review.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.