[Bug 627274] [cpureport][PATCH] Improve precission of cpu time information

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 23 03:48:01 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=627274
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168722|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-23 10:48:00 UTC ---
Review of attachment 168722:
 --> (https://bugzilla.gnome.org/review?bug=627274&attachment=168722)

::: gst/debugutils/cpureport.c
@@ +42,3 @@
+  static const GEnumValue cpu_clock_mode[] = {
+    {CLOCK_PROCESS_CPUTIME_ID, "Process cpu time", "process"},
+    {CLOCK_THREAD_CPUTIME_ID, "Thread cpu time", "thread"},

Are these defined to the same numbers everywhere? Otherwise please add your own
constants for them and map them later to the POSIX constants.

And only use this conditionally if available. I think these are only available
on POSIX too, for everything else just do what was done before.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list