[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #37 from Alexey Fisher <bug-track at fisher-privat.net> 2011-05-28 04:24:46 UTC ---
(In reply to comment #36) 
> Did you test that this produces the correct output, as we've discussed it
> earlier in this bug?

Yes, it reproduce exact same stream.

> And do you have any idea how to fix the discont check function?

It will be good to reset the frame interval counter each time we set a GAP
frame in the queue. For simple VFR stream it will make sense to make the frame
interval, before reset, tunable or just bigger.

> ::: ext/theora/gsttheoraenc.c
> @@ +1095,3 @@
> +  g_assert (enc->t_queue != NULL);
> +
> +  ptr = g_malloc (sizeof (GstClockTime));
> 
> Oh right, we're talking about guint64 here and can't just store them in the
> GQueue. The best might be to implement your own simple ringbuffer on top of an
> array then for the queue... or at least use GSlice to allocate the elements.
> Sorry

Ok, i will use g_slice_alloc.

> @@ +1343,3 @@
> +        theora_timefifo_in (enc, &timestamp);
> +        /* We should haveone frame delay to create correct frame order.
> +         * First time we got buuffer, prevbuf should be empty. Nothing alse
> 
> Typos ;)
> 
> @@ +1355,3 @@
> +          t_queue_lenght++;
> +
> +          if (t_queue_lenght > 2) {
> 
> and yet another typo, length :)

I'll do it USUP after hospital.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.