[Bug 663186] New: taginject is not gap aware

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663186
  GStreamer | gst-plugins-good | git

           Summary: taginject is not gap aware
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: channa at caltech.edu
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


taginject subclasses GstBaseTransform but does not appear to be gap aware. 
Given the nature of the element I assume there is no reason for it not to be
gap aware and that it is simply an oversight.  I haven't tested this patch yet,
but I think something like this would make it gap aware:

diff --git a/gst/debugutils/gsttaginject.c b/gst/debugutils/gsttaginject.c
index a5e78fe..e0c9d2c 100644
--- a/gst/debugutils/gsttaginject.c
+++ b/gst/debugutils/gsttaginject.c
@@ -134,6 +134,8 @@ gst_tag_inject_class_init (GstTagInjectClass * klass)
 static void
 gst_tag_inject_init (GstTagInject * self, GstTagInjectClass * g_class)
 {
+  GstBaseTransform *trans = GST_BASE_TRANSFORM (self);
+  gst_base_transform_set_gap_aware (trans, TRUE);
   self->tags = NULL;
 }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.