[Bug 661262] [pulseaudiosink] Playbin2 fails playing mkv with ac3 as pulseaudiosink to accept ac3

Thu Nov 3 02:12:53 PDT 2011

https://bugzilla.gnome.org/show_bug.cgi?id=661262
  GStreamer | gst-plugins-good | git

--- Comment #41 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-03 09:12:50 UTC ---
commit b29a3d3cfffa418f8cdfd4c83a1750dc96039695
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Thu Nov 3 10:07:27 2011 +0100

    playsinkconvertbin: Don't add identity multiple times

commit 7eb8a9aaf6c0bf92a35e2c3f35ba7398eb8f6988
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Oct 19 14:13:39 2011 +0100

    playsink: send flush start/stop event when we switch elements

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 0cac680faccd6d2c1396339f1994a63d971697d2
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Oct 19 14:13:30 2011 +0100

    playsink: re-add identity where appropriate

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit c3e94d1c0890f5dcc139d29692bb588ae6f5d48e
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Oct 19 14:12:01 2011 +0100

    playsink: lock the new {set,get}_property functions

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 0a07701164a35f736ba8ba881bbcc12e9f9140ce
Author: Thiago Santos <thiago.sousa.santos at collabora.com>
Date:   Mon Oct 17 23:14:54 2011 +0000

    playsinkconvertbin: Be more consistent with ghostpad targets

    Set up targets on READY->PAUSED state change to passthrough by
    default. This prevents the targets from being unset on the
    first run, while the 'raw' variable would mean that some
    target is set.

commit f9ea3fdda8c391afc17cb7b110a998d333d12059
Author: Thiago Santos <thiago.sousa.santos at collabora.com>
Date:   Mon Oct 17 22:41:49 2011 +0000

    playsinkconvertbin: No need to remove the identity

    The identity element should be handled by the GstBin's cleanup,
    removing it on the remove_elements function might remove it
    too soon, as this function can be called directly from playsink

commit 34f72da9cc41e4b1e94dc175efdc386751b266ce
Author: Thiago Santos <thiago.sousa.santos at collabora.com>
Date:   Mon Oct 17 22:41:11 2011 +0000

    playsinkconvertbin: Adding some debug messages

    Adds a couple debug messages and some g_assert to make debugging
    easier

commit 80971a3b337f8083afd06aa63cb01eb5f3f67585
Author: Thiago Santos <thiago.sousa.santos at collabora.com>
Date:   Mon Oct 17 22:02:03 2011 +0000

    playsink-videoconvert: Fix warning on build

    Remove unused variable

commit ae3ba533914d7961248190bc56734d7b6fe2b716
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 21:05:30 2011 +0000

    playsink: handle after-the-fact changes in converters/volume booleans

    The playsink was nastily poking a boolean in the structure.
    Make those booleans properties, so we are told when they change,
    and rebuild the conversion bin when they do.

    Some cleanup to go with it too.

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit c08a23169d85b47c28ce8ded06a80b90c02ef8cc
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 18:43:06 2011 +0000

    playsink: handle NULL cached caps in getcaps

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 3939457b00f3ae81833c41b8fbab2bed5099aee9
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 18:06:00 2011 +0000

    playsink: consider both passthrough and converter caps in getcaps

    Since we can switch between both modes.

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit b34dac9a8737eb5b9e16e86ba2553c9758990e3a
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 17:54:27 2011 +0000

    playsink: cache inner converter bin caps

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 6925c02bc23091a250bfbf2aba68e469b9cf2e4e
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 17:26:48 2011 +0000

    playsink: keep both raw and non raw pipelines at all times

    and switch between them as needed.

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 69d98d08c193c5ee21775b0cc8ef6b0a6c6d0089
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 17:29:50 2011 +0000

    playsink: only compare against the media type we expect

    ie, audio/x-raw- for audio, video/x-raw- for video.

    Add a trailing - to be more specific. I doubt there's anything
    like audio/x-rawhide or something, but you never know.

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit fd27e34582fb8785e741785e265380497bf15e14
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 16:55:30 2011 +0000

    playsink: refactor the converter bins since they are almost identical

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit c8e0d215cbaf9ffc0713fe8c060b52af7ffff958
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Oct 17 13:00:05 2011 +0000

    playsink: fix passthrough mode (hopefully)

    The code was doing counterintuitive rewiring of pads when the
    bin did not contain any elements. We now add an identity element
    in that case, which makes it simpler, and should fix the AC3
    passthrough mode when using pulseaudio (but I don't see the bug
    here so can't test).

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit 2b84b328b1cac2c083fb322f4abb91bf439fb944
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Oct 7 11:16:44 2011 +0000

    playsink: handle NULL ghost pad target

    For the src pad anyway.

    https://bugzilla.gnome.org/show_bug.cgi?id=661262

commit a583b63722d2397914ad2e774df0ea6ba2b9d8ba
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Thu Nov 3 09:56:14 2011 +0100

    Revert "playsinkaudioconvert: Fix warning when there is no target pad yet"

    This reverts commit f35c51c14915729f0fdf2b348f351ea7e81027cc.

    Better patch coming soon.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.