[Bug 663312] decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663312
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200587|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-03 12:50:01 UTC ---
Review of attachment 200587:
 --> (https://bugzilla.gnome.org/review?bug=663312&attachment=200587)

Looks good, only_

::: gst/playback/gstdecodebin2.c
@@ +3470,3 @@
     elem_next = delem_next->element;

+    caps = _gst_element_get_linked_caps (elem_next, elem, &srcpad);

You're leaking the srcpad in the caps==NULL case

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.