[Bug 662207] gst: Fix a lot of GLib deprecations and errors

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Nov 3 12:36:16 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=662207
  GStreamer | gstreamer (core) | unspecified

Jasper St. Pierre <jstpierre> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199445|0                           |1
        is obsolete|                            |

--- Comment #11 from Jasper St. Pierre <jstpierre at mecheye.net> 2011-11-03 19:36:06 UTC ---
Created an attachment (id=200641)
 View: https://bugzilla.gnome.org/attachment.cgi?id=200641
 Review: https://bugzilla.gnome.org/review?bug=662207&attachment=200641

gst: Fix a lot of GLib deprecations and errors

Yes, I ran out of steam and only fixed the main library, not anything in
libs/gst/base. This patch also breaks ABI, so it will have to wait until we can
break the ABI again. For now, just build with deprecations off. Do something
like:

    make GLIB_EXTRA_CFLAGS='-UDISABLE_GLIB_DEPRECATIONS'

to do that.

The gsttask.c replacement is also horribly incorrect, and I knew this at the
time of filing. Unfortunately, there are and will not be replacements for
g_rec_mutex_lock_full g_rec_mutex_unlock_full, so someone is going to rewrite
the gsttask.c code so that it doesn't play horrible hacks with locks. That
someone will not be me.

I'm updating this patch to apply to master, because it's an easy job, and
someone can use this patch as a starting point to unbreak deprecations when ABI
breaks. I'm not really a gstreamer developer, so I don't know the code that
well. This is my first time ever looking at gstreamer code, actually. I just
dug in and replaced gst_mutex_new with the associated equivalents.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list