[Bug 663406] [0.11] gstpluginfeature: make most of this structure private

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663406
  GStreamer | gstreamer (core) | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-11-07 23:25:16 UTC ---
Thanks for working on this.

Only had a quick glance, but my first impression is that not all functions
should be public. IMHO external code doesn't really have any reason to create a
plugin feature object, or set the loaded state, or set the plugin name, so
these look like they should be private functions IMHO:

+void            gst_plugin_feature_set_loaded           (GstPluginFeature *
feature);
+void            gst_plugin_feature_set_plugin_name      (const
GstPluginFeature * feature, const gchar *);
+void            gst_plugin_feature_setup                (GstPluginFeature *
feature,
+                                                         const gchar * name,
GstPlugin * plugin,
+                                                         guint rank, gboolean
set_loaded);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.