[Bug 662775] dv1394src: Add support for old kernels

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=662775
  GStreamer | gst-plugins-good | git

--- Comment #8 from Andoni Morales <ylatuya at gmail.com> 2011-11-08 12:41:32 UTC ---
Review of attachment 200034:
 --> (https://bugzilla.gnome.org/review?bug=662775&attachment=200034)

::: ext/raw1394/gst1394clock.c
@@ +120,3 @@
+    if (err) {
+      GST_ERROR_OBJECT (clock, "Error reading cycle timer");
+      return GST_CLOCK_TIME_NONE;

_have_rct defines whether the kernel support this call, which is checked when
setting the clock handle.

I see 3 scenarios here:
  * This call is not supported, returning always an error value,  and _have_rct
is properly set to FALSE setting the clock handle.
  * This call is supported and _have_rct is properly set to TRUE in the first
call, but we can still fail reading the timer from time to time, which should
never happen and that's why _have_crt is not reset here
  * This call is supported and _have_crt is badly set to FALSE because the
first call to the function returned with an error, which also should never
happen

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.