[Bug 662952] compiler warnings if debugging system is disabled

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=662952
  GStreamer | gstreamer (core) | git

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-11-09 22:05:58 UTC ---
> Tim, are you sure disabling the warning is the right way to do it? In many
> cases one could spare the local variable instead. Especially when you disable
> debug, you would also like to avoid determining things that are not used (In
> theory the compiler will eliminate the unused expressions).

Well, I recognise that occasionally there may be some value in doing that sort
of thing, however:

 - I don't think we really want to "officially" support warning-free builds
   of all modules with the debugging system disabled (same for other
   options really). If you want to be the one taking care of that, go for
   it.

 - I personally don't want to see the source code cluttered with
    #ifdef GST_DISABLE_GST_DEBUG
   crap all over the place just to avoid warnings like these (or see
   code uglified in other ways just to avoid warnings)

 - in most cases we fix stuff by just adding G_GNUC_UNUSED stuff
   anyway, which pretty much has the same effect as just suppressing
   the warning

 - if someone has too much spare time and is really keen on tracking
    down truly unnecessary variables/assignments/calls, they can still
    easily do so by adding to / overiding the warning flags.

 - my hope is that the compiler will just eliminate such unused
   variables / expressions (or, if that's not done by default, that
   there's at least a way to "encourage" the compiler to do that).


So no, I'm not sure, but then my first instinct was to just WONTFIX the bug.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.