[Bug 664443] New: [gsth264parser.c] Parsing shifts timestamps between frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664443
  GStreamer | gst-plugins-bad | 0.10.x

           Summary: [gsth264parser.c] Parsing shifts timestamps between
                    frames
    Classification: Platform
           Product: GStreamer
           Version: 0.10.x
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: matej.knopp at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Buffer for first frame ends with 0x00, 
Buffer for second frame start with 0x00 0x00 0x01 0x09

The following code in gsth264parser.c

/* sc might have 2 or 3 0-bytes */
  if (nalu->sc_offset > 0 && data[nalu->sc_offset - 1] == 00)
    nalu->sc_offset--;

assumes that the trailing zero byte from first frame is part of second frame
start code. This results in gst_h264_parse_check_valid_frame returning fsize
one byte smaller than it should be. Later fsize of bytes is taken from adapter,
but since there is one last byte from first buffer, the timestamp for second
frame is same as timestamp for first frame, which is wrong.

Removing the code fixes this but I don't know if it has any side effects.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.