[Bug 640017] basevideodec should emit Qos GstMessage when dropping frame

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640017
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202024|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-24 07:32:20 UTC ---
Review of attachment 202024:
 --> (https://bugzilla.gnome.org/review?bug=640017&attachment=202024)

::: gst-libs/gst/video/gstbasevideodecoder.c
@@ +1491,3 @@
+    /* FIXME: do we need a way to mark frames that should not be counted as
+     * dropped (e.g. "invisible frames")? */
+    base_video_decoder->dropped++;

As discussed on IRC yesterday we need something for this, yes. Best would be
new API to distinguish dropping of frames and frames without a src_buffer, e.g.
gst_base_video_decoder_drop_frame().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.