[Bug 663174] oggmux: set collectpads2 not to wait on sparse streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663174
  GStreamer | gst-plugins-base | unspecified

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-24 09:34:57 UTC ---
Review of attachment 200423:
 --> (https://bugzilla.gnome.org/review?bug=663174&attachment=200423)

::: ext/ogg/gstoggmux.c
@@ +467,3 @@
       oggpad = (GstOggPadData *)
           gst_collect_pads2_add_pad_full (ogg_mux->collect, newpad,
+          sizeof (GstOggPadData), gst_ogg_mux_ogg_pad_destroy_notify, FALSE);

Are you sure this shouldn't be left as TRUE

@@ +993,3 @@
+                GST_DEBUG_OBJECT (pad, "Pad is sparse, marking as such");
+                gst_collect_pads2_set_waiting (ogg_mux->collect,
+                    (GstCollectData2 *) pad, FALSE);

...and only changed here for sparse streams?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.