[Bug 595055] [pulsesrc] Should implement GstStreamVolume interface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595055
  GStreamer | gst-plugins-good | 0.10.25

Sjoerd Simons <sjoerd> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sjoerd at luon.net

--- Comment #5 from Sjoerd Simons <sjoerd at luon.net> 2011-11-24 10:21:37 UTC ---
(In reply to comment #4)
> Created an attachment (id=202044)
 View: https://bugzilla.gnome.org/attachment.cgi?id=202044
 Review: https://bugzilla.gnome.org/review?bug=595055&attachment=202044

> pulsesrc: Implement GstStreamVolume interface
> 
> PulseAudio 1.0 supports per-source-output volumes, and this exposes the
> functionality via the GstStreamVolume interface.
> 
> When compiled against pre-1.0 PulseAudio, the interface is not
> implemented, and using the "volume" or "mute" property is a no-op. This
> bit of ugliness will go away when we can depend on PulseAudio 1.0 or
> greater.

Code looks good to me. I was wondering whether instead of expose no-op
properties instead pulsesrc should not expose the property if compiled with
older pulseaudio. As any good application would check for the
property/interface at run-time anyway to nicely support both older and newer
gst-plugins-good

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.