[Bug 665004] audioresample emits spurrious disconts

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=665004
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.36

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-28 17:03:37 UTC ---
Please attach patches in "git format-patch" format in the future :)

commit 4c52f4e625f910d6fba34d49fe06cfd1220c9c93
Author: Kipp Cannon <kcannon at cita.utoronto.ca>
Date:   Mon Nov 28 17:59:32 2011 +0100

    audioresample: Don't emit DISCONT buffers if no discontinuity happened

    audioresample is derived from GstBaseTransform, and one of
    GstBaseTransform's traits is that if the derived element does not
    produce an output buffer from some input buffer then the first output
    buffer after that gets flaged as a discontinuity, whether or not the
    buffer actually is discontinuous from the output buffer that preceded
    it. When downsampling, the audioresample element requires more than
    one input sample for each output sample, and if the ratio of input to
    output sample rates is high enough and the input buffers short enough
    it can come to pass that the resampler does not receive enough samples
    on its input to produce any output.  Currently the resampler returns
    GST_BASE_TRANSFORM_FLOW_DROPPED from the transform() method in this case,
    causing the next buffer to be flagged as a discontinuity. If subsequent
    elements in the pipeline reset themselves on disconts, this can cause
    clicks and other undesireable behaviour.

    Fixes bug #665004.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.