[Bug 656115] [PATCH] mpegpsdemux: recalculate adjust if diffenrence is negative

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 29 03:14:21 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=656115
  GStreamer | gst-plugins-bad | git

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193384|none                        |reviewed
             status|                            |

--- Comment #1 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-11-29 11:14:18 UTC ---
Review of attachment 193384:
 --> (https://bugzilla.gnome.org/review?bug=656115&attachment=193384)

Since the code just above specifically tests if the new ts is higher or lower
and orders
the operation based on this, it would make more sense to just make diff a
guint64 in the
first place. The check should then just work without having to test for < 0.
Various typos/spelling/grammar mistakes too (diffenrence, reajust, they was,
scip).
I think you're not a native English speaker, but some are easily fixed on
re-read typos.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list