[Bug 660598] playbin2: Make sure that elements that are plugged are compatible with the fixed sink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660598
  GStreamer | gst-plugins-base | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197918|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-10-03 08:22:47 UTC ---
Review of attachment 197918:
 --> (https://bugzilla.gnome.org/review?bug=660598&attachment=197918)

Looks good in general, just two comments:

::: gst/playback/gstplaybin2.c
@@ +3231,3 @@
+    /* If it is not a video element and we don't have a fixed video sink
+     * we try the factory */
+    if (!strstr (klass, "Video") || !group->video_sink) {

Don't do this only for video but also for audio and the audio-sink

@@ +3240,3 @@
+
+      if ((sinkpad = gst_element_get_static_pad (group->video_sink, "sink")))
{
+        caps = gst_pad_get_caps (sinkpad);

gst_pad_get_caps_reffed() here, and don't forget to unref the caps after use

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.