[Bug 660275] jpegdec doesn't implement upstream negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660275
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197594|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-10-03 09:36:46 UTC ---
Review of attachment 197594:
 --> (https://bugzilla.gnome.org/review?bug=660275&attachment=197594)

Looks good, please push after fixing these two comments:

::: ext/jpeg/gstjpegdec.c
@@ +785,3 @@
+    return gst_caps_ref (GST_PAD_CAPS (pad));
+
+  peer = gst_pad_get_peer (dec->srcpad);

You're leaking the peer here

@@ +805,3 @@
+
+    templ_caps = gst_pad_get_pad_template_caps (pad);
+    caps = gst_caps_intersect (peer_caps, templ_caps);

intersect_full (peer_caps, templ_caps, GST_CAPS_INTERSECT_FIRST) makes more
sense here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.