[Bug 662330] Auto-plugger should link first then test

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=662330
  GStreamer | gst-plugins-base | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199584|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-10-21 06:53:08 UTC ---
Review of attachment 199584:
 --> (https://bugzilla.gnome.org/review?bug=662330&attachment=199584)

Good idea and looks good in general, just two minor comments

::: gst/playback/gstdecodebin2.c
@@ +178,3 @@
+
+  GMutex *filtered_lock;
+  GList *filtered;              /* element for which error message are filterd
*/

You should be able to use the object lock here instead of introducing a new
mutex.

@@ +1090,3 @@
+    g_mutex_free (decode_bin->filtered_lock);
+    decode_bin->filtered_lock = NULL;
+  }

Just to be on the safe side, please also free the list of filtered elements
here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.