[Bug 651443] Adding a size-limit property to multifilesink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=651443
  GStreamer | gst-plugins-good | git

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188865|none                        |needs-work
             status|                            |

--- Comment #2 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-10-28 12:13:37 UTC ---
Review of attachment 188865:
 --> (https://bugzilla.gnome.org/review?bug=651443&attachment=188865)

::: gst/multifile/gstmultifilesink.c
@@ +546,3 @@
+        filename = g_strdup_printf (multifilesink->filename,
+            multifilesink->index);
+        multifilesink->file = g_fopen (filename, "wb");

This uses glib g_fopen, but the above uses libc close.
In any case, looking at the existing code, the open/close code was refactored
so you can now make use of this new code instead.

@@ +554,3 @@
+
+      ret = fwrite (GST_BUFFER_DATA (buffer), GST_BUFFER_SIZE (buffer), 1,
+          multifilesink->file);

The blocks are written as one chunk, which means the size limit is only
approximate. It'd be more intuitive to write buffers in more than one file if
necessary.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.