[Bug 577784] Implement full H.263/+/++ caps negotiation according to RFC4629
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Sep 5 04:03:18 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=577784
GStreamer | gst-plugins-good | git
--- Comment #24 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-09-05 11:03:11 UTC ---
As good a time as any to (finally) push these, so:
commit d4778dbe4341ddc13c1ce9214ae21a2e15cba25d
Author: Olivier Crête <olivier.crete at collabora.co.uk>
Date: Wed Mar 4 14:51:09 2009 -0500
rtph263ppay: Set H263-2000 if thats what the other side wants
The static caps states this element supports H263-2000, but setcaps never
sets it, so it was lie.
See https://bugzilla.gnome.org/show_bug.cgi?id=577784
However, noticed something in the good-0002 patch:
+ peercaps = gst_pad_peer_get_caps (GST_BASE_RTP_PAYLOAD_SRCPAD (payload));
+ if (!peercaps)
+ return
+ gst_caps_copy (gst_pad_get_pad_template_caps
+ (GST_BASE_RTP_PAYLOAD_SRCPAD (payload)));
Should that not use the template caps of _SINKPAD (in a sink getcaps function)
rather than of the SRCPAD ?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list