[Bug 644768] [dcaparse] implement 14-to-16-bit conversion

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644768
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196047|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-09 11:00:11 UTC ---
Review of attachment 196047:
 --> (https://bugzilla.gnome.org/review?bug=644768&attachment=196047)

::: gst/audioparsers/gstdcaparse.c
@@ +171,3 @@
+  peercaps = gst_pad_peer_get_caps (GST_BASE_PARSE_SRC_PAD (dcaparse));
+  if (peercaps == NULL)
+    return;

Don't you need to set the _negotiated fields of the instance to something
sensible here? Otherwise negotiate will be called for every single buffer

@@ +481,3 @@
+    } else {
+      endianness = G_LITTLE_ENDIAN;
+    }

Maybe use a ternary operator here ;)

@@ +484,3 @@
+  }
+
+  if (depth == 14 && dcaparse->depth_negotiated == 16) {

Don't you also need downwards converting code from 16 to 14 bits here? And is
this code working for both endiannesses?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.