[Bug 657343] [patch] add PES support

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 15 08:17:05 PDT 2011

  GStreamer | gst-plugins-bad | git

Stas Sergeev <stsp> changed:

           What    |Removed                     |Added
 Attachment #194818|0                           |1
        is obsolete|                            |
 Attachment #194887|0                           |1
        is obsolete|                            |

--- Comment #16 from Stas Sergeev <stsp at list.ru> 2011-09-15 15:17:01 UTC ---
Created an attachment (id=196643)
 View: https://bugzilla.gnome.org/attachment.cgi?id=196643
 Review: https://bugzilla.gnome.org/review?bug=657343&attachment=196643


It seems there is some confusion in the pesparser code of
tsdemux plugin... I don't know what this part was supposed
to do at all:
      flags = *data++;
      /* Only valid if stream_id_extension_flag == 0x0 */
      if (!(flags & 0x80)) {
        res->stream_id_extension = flags & 0x7f;
If bit 7 is not set (!(flags & 0x80)), there is no use of
doing flags & 0x7f on the next line, is it?
Moreover, I failed to track that to the description of the
pes header format, and in fact mpegtsmux can write different
values there: 0x60, 0x71, 0x80 and 0x82 to specify the media
type, so the 0x7f mask cannot be applied.
So the code looks totally wrong and misplaced, probably a
copy/paste bug.
the attached patch removes the code in question, allowing my
plugin to get the media type.

I am removing the plugins implementation for now: will re-upload
when they are finished. Let's see if at least the fixes can be
processed and applied to that date.

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list