[Bug 621897] [oggdemux] reports wrong duration
bugzilla at gnome.org
Fri Sep 16 10:27:13 PDT 2011
GStreamer | gst-plugins-base | git
--- Comment #19 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-09-16 17:27:09 UTC ---
> > [would be nice to give the user feedback that something is happening]
> That's out of the purview of a demuxer, no ? What would you suggest ?
Don't know yet, something to do some other time, not really essential to this
> > why not just use the sinkpad's stream lock?
> I actually tried that a couple days back. It did not go well, there
> was a deadlock, which I can't recall the details of, but it did make
> some kind of sense from the backtrace IIRC.
> It would also add more contention, as the stream lock is held for
In the normal case (streaming) there should be no contention at all really,
because only the streaming thread takes/releases the lock. But it's no biggie
anyway, can always be changed later. Was just wondering if there was a reason
> > - GST_PUSH_LOCK/UNLOCK should probably be
> > inside of
any if (!ogg->pullmode) instead of
> > outside of it? (see e.g. submit_packet)
> It usually is, except in the cases where the test is compound with
> another push_ member, which needs locking. I could split the test,
> and lock in the middle, but it would add nesting. I think it's OK
> as it is, but I don't mind doing this if you think it's better.
Ok, I guess that makes sense. I think there's seomthing to be said for really
keeping all the push code stuff 100% in push mode code paths, but I see your
point about indentation. Let's keep it as it is for now then.
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs