[Bug 659114] [core] Some nifty corrections and spellchecking

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=659114
  GStreamer | gstreamer (core) | 0.11.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196664|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-19 07:44:42 UTC ---
Review of attachment 196664:
 --> (https://bugzilla.gnome.org/review?bug=659114&attachment=196664)

::: gst/gstcaps.c
@@ +62,3 @@
  * or intersecting.
  *
+ * Last reviewed on 2011-9-14 (0.11)

I think 0.10.36 would be better

@@ +196,3 @@
  * Creates a new #GstCaps that is empty.  That is, the returned
  * #GstCaps contains no media formats.
+ * Caller is responsible for dereferencing the returned caps.

It's not dereferencing but "unreferencing", i.e. gst_caps_unref()

@@ +243,3 @@
  * structure is defined by the arguments, which have the same format
  * as gst_structure_new().
+ * Caller is responsible for dereferencing the returned caps.

Same here

@@ +336,3 @@
  * Converts a #GstStaticCaps to a #GstCaps.
  *
+ * Returns: (transfer full): a pointer to the #GstCaps. Dereference after
usage.

and here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.