[Bug 657343] [patch] add PES support

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 19 01:31:42 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=657343
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196643|none                        |needs-work
             status|                            |

--- Comment #17 from Edward Hervey <bilboed at gmail.com> 2011-09-19 08:31:36 UTC ---
Review of attachment 196643:
 --> (https://bugzilla.gnome.org/review?bug=657343&attachment=196643)

::: gst/mpegtsdemux/pesparse.c
@@ +337,2 @@
     if (res->extension_field_length) {
+      res->stream_id_extension_data = data;

There seems to be something missing here.

The original code does:
* read and advance data by 1 byte
* advance data by res->extension_field_length

Your code does:
* read data byte
* advance data by res->extension_field_length

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list