[Bug 655112] Improve videomaxrate caps negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=655112
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196920|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-19 11:47:29 UTC ---
Review of attachment 196920:
 --> (https://bugzilla.gnome.org/review?bug=655112&attachment=196920)

::: gst/videorate/gstvideorate.c
@@ +274,3 @@
+    *max_num = gst_value_get_fraction_numerator (max);
+    *max_denom = gst_value_get_fraction_denominator (max);
+  } else if (GST_VALUE_HOLDS_LIST (v)) {

It could also be a fraction range and quite often is

@@ +327,3 @@
+  s2 = gst_structure_copy (s);
+
+  if (videorate->drop_only) {

You should probably call gst_base_transform_reconfigure() whenever this
property changes now

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.