[Bug 659943] [ac3parse] it does not correcly check for ac3/e-ac3 switch

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Sep 23 08:43:13 PDT 2011

  GStreamer | gst-plugins-good | git

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> 2011-09-23 15:43:08 UTC ---
Well, this is a ac3 stream where there is one e-ac3 buffer at some point.
Actually I encountered it when decodein a iec61937 stream (around spdif).

In gst_ac3_parse_parse_frame of gstac3parse.c, there is a "if (G_UNLIKELY
(sid)) {" at line 583.

In my context, the sid of this e-ac3 buffer is 7 and sample rate 48000 so the
next "return GST_FLOW_OK;" is executed.

Reading the code I found the incorrect ac3parse->eac != ac3parse->eac.

Note that the fix does not resolve the e-ac3 buffer detection because of the
"return GST_FLOW_OK;"

I think the check "if (G_LIKELY (ac3parse->sample_rate > 0))" at line 593 is
not enough,  it should also check for ac3parse->eac == eac or something

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list