[Bug 660255] New: [theoraenc] Fix handling of GstForceKeyUnit events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660255
  GStreamer | gst-plugins-base | git

           Summary: [theoraenc] Fix handling of GstForceKeyUnit events
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: ylatuya at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=197582)
 View: https://bugzilla.gnome.org/attachment.cgi?id=197582
 Review: https://bugzilla.gnome.org/review?bug=660255&attachment=197582

Fix handling of GstForceKeyUnitEvents

This fixes how GstForceKeyUnit events are handled:

  * Reuse the upstream event instead of creating a new one, keeping all the
fields from the original event

  * Don't call theora_enc_force_keyframe() from the sink_event function. It
calls theora_enc_reset() which can also be called from a different thread in
the setcaps function generating a segfault:
   GST_EVENT gstpad.c:5097:gst_pad_send_event:<encoder:sink> have event type
custom-downstream
   ** ERROR:gsttheoraenc.c:478:theora_enc_reset: assertion failed:
(enc->encoder != NULL)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.