[Bug 659798] Segfault when you convert with audioconvert from audio file mkv to audio file avi
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Sep 27 22:29:45 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=659798
GStreamer | gst-plugins-good | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #197575|none |needs-work
status| |
--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-28 05:29:38 UTC ---
Review of attachment 197575:
--> (https://bugzilla.gnome.org/review?bug=659798&attachment=197575)
::: gst/matroska/matroska-demux.c
@@ +3537,3 @@
+ GST_BUFFER_DATA (sub) = copy;
+ /* Sub buffers don't have their own memory to free */
+ GST_BUFFER_MALLOCDATA (sub) = copy;
Better create a new buffer here, the subbuffer will still point at the parent
buffer and this might confuse some code. On the new buffer use something like
gst_buffer_copy_metadata() to copy all the stuff.
Also better use guchar instead of unsigned char for consistency ;)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list