[Bug 660364] opus: misc cleanup/fixes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660364
  GStreamer | gst-plugins-bad | unspecified

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-29 07:17:19 UTC ---
Review of attachment 197668:
 --> (https://bugzilla.gnome.org/review?bug=660364&attachment=197668)

::: ext/opus/gstopusdec.c
@@ -611,3 @@
-  dec->frame_size = dec->header.frame_size;
-#else
-  opus_mode_info (dec->mode, OPUS_GET_FRAME_SIZE, &dec->frame_size);

You don't set dec->frame_size anywhere, is this correct?

::: ext/opus/gstopusenc.c
@@ -693,3 @@
-  enc->frame_size = enc->header.frame_size;
-#else
-  opus_mode_info (enc->mode, OPUS_GET_FRAME_SIZE, &enc->frame_size);

Same here about the frame_size and additionally the header creation

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.