[Bug 660364] opus: misc cleanup/fixes

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 29 02:20:27 PDT 2011

  GStreamer | gst-plugins-bad | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #8 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-09-29 09:20:24 UTC ---
> You don't set dec->frame_size anywhere, is this correct?

No, it's set via:

  if (!gst_structure_get_int (s, "frame-size", &dec->frame_size)) {
    GST_WARNING_OBJECT (dec, "Frame size not included in caps");

> Same here about the frame_size and additionally the header creation

This was already set in existing code, gst_opus_enc_sink_setcaps.
As for any header, I'm not too sure what to do with that. There is a header
when embedded in Ogg (ID header, and comments), but apparently not in other
The code calling the header stuff was all commented out anyway. I guess I'll
come back to that when I get some time and fix up what needs fixing up for Ogg
framing, which will include that header stuff (not sure if the ogg mapping is
fully defined yet though).

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list