[Bug 607619] [typefind] utf-16 text file mistakenly identified as layer 1 mpeg audio

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607619
  GStreamer | gst-plugins-base | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #6 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-09-30 19:39:10 UTC ---
> What's the point of this mp3 typefinder rant?

No real point, removed.

> Do you have any evidence that it is "barely recognizing valid MP3 as MP3" in
> general?

I've had a couple bugs where it was failing to recognize MP3 as such (one of
those was due to an ID3 tag with padding, can't recall the other). I've a
couple others where it was recognizing other stuff as MP3. I don't know if it's
really the MP3 format itself being the reason, or the typefinder though.

> Hrm, I wonder if there's something better we can do here that avoids allocs..
> (let's keep in mind that we're going to be running this four times for every
> blob of data that's not immediately identified with a 100% probability).

Fair point. g_convert internally ends up calling iconv, and the manpage
suggests the output buffer cannot be NULL, so we'd have to reimplement
UTF-{16,32} parsing manually. A medium way would be to call iconv ourselves,
with a buffer allocated once only, instead of 4 times. Or realloc a static
buffer that would "leak", but only one alloc per process.

> greater or *equal* 0 ?

It was initialized to -1, so >= 0 means it had been modified.
it doesn't make much sense though, you're right, so now > 0.

> Can we do the gst-indent updates in a separate patch?

Gah, didn't realize gst-indent had done that. Removed.

Points not replied to here are done.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.