[Bug 673211] [0.10] playsink should push events on all its internal sinks

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Apr 3 23:32:36 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=673211
  GStreamer | gst-plugins-base | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210998|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-04-04 06:32:32 UTC ---
Review of attachment 210998:
 --> (https://bugzilla.gnome.org/review?bug=673211&attachment=210998)

Looks good in general. What should be the "preview" mode?

Please push this to 0.10 and master (0.11) after addressing the comment below

::: gst/playback/gstplaysink.c
@@ +80,3 @@
+          "mode-default"},
+      {MODE_FIRST, "Sends the event to sinks until the first one handles it",
+          "mode-first"},

The last fields of the GEnumValue struct can simple be "default" and "first".
Less annoying to use :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list