[Bug 654900] [gdppay] Sending a duplicated newsegment event for every tag event

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654900
  GStreamer | gst-plugins-base | 0.10.13

Guillaume Emont <gemont> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207784|0                           |1
        is obsolete|                            |

--- Comment #5 from Guillaume Emont <gemont at igalia.com> 2012-04-11 11:42:08 UTC ---
Created an attachment (id=211823)
 View: https://bugzilla.gnome.org/attachment.cgi?id=211823
 Review: https://bugzilla.gnome.org/review?bug=654900&attachment=211823

gdpdepay: Avoid sending twice the same newsegment event

Here is a first attempt at fixing this on the side of gdpdepay. This patch
seems to work, but has a few suspected drawbacks:
 - I suspect that the following case is possible (at least theoretically, and
we break it): if upstream sends a newsegment event that is identical to the
last one it sent, but actually wants them to be accumulated
 - not sure it's safe to add a field to GstGDPDepay (ABI breakage)
 - We probably need to reset ->last_newsegment_event in some places (like when
flushing or when going to READY)

Anyway, I still need to understand better how the streamheader thing works and
if/why the previous patch actually breaks that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.