[Bug 673897] tsdemux: Fix crash due to NULL pointer access.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Apr 18 00:25:56 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=673897
  GStreamer | gst-plugins-bad | git

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-04-18 07:25:54 UTC ---
Review of attachment 211820:
 --> (https://bugzilla.gnome.org/review?bug=673897&attachment=211820)

::: gst/mpegtsdemux/tsdemux.c
@@ -1504,3 @@
       GST_EVENT_SRC (demux->update_segment) = gst_object_ref (demux);
     }
-    demux->calculate_update_segment = FALSE;

Any reason why you removed this line here?

@@ +1517,3 @@
   if (demux->update_segment) {
     GST_DEBUG_OBJECT (stream->pad, "Pushing update segment");
+    GST_EVENT_SRC (demux->segment_event) = gst_object_ref (demux);

Setting the src doesn't make much sense at all, the pad will be set as src
later

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list