[Bug 673897] tsdemux: Fix crash due to NULL pointer access.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=673897
  GStreamer | gst-plugins-bad | git

--- Comment #7 from Julian Scheel <julian at jusst.de> 2012-04-18 07:54:55 UTC ---
(In reply to comment #2)
> Review of attachment 211820 [details]:
> 
> ::: gst/mpegtsdemux/tsdemux.c
> @@ -1504,3 @@
>        GST_EVENT_SRC (demux->update_segment) = gst_object_ref (demux);
>      }
> -    demux->calculate_update_segment = FALSE;
> 
> Any reason why you removed this line here?

No, this was simply wrong, sorry. Uploaded a wrong patch file and didn't see
it. The newly uploaded one is correct.

> @@ +1517,3 @@
>    if (demux->update_segment) {
>      GST_DEBUG_OBJECT (stream->pad, "Pushing update segment");
> +    GST_EVENT_SRC (demux->segment_event) = gst_object_ref (demux);
> 
> Setting the src doesn't make much sense at all, the pad will be set as src
> later

Then we can simply remove it? Instead of moving it down here? I just moved it
as it was in there before and cause the crash.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.