[Bug 673897] tsdemux: Fix crash due to NULL pointer access.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=673897
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Julian Scheel <julian at jusst.de> 2012-04-18 08:35:42 UTC ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> > > @@ +1517,3 @@
> > >    if (demux->update_segment) {
> > >      GST_DEBUG_OBJECT (stream->pad, "Pushing update segment");
> > > +    GST_EVENT_SRC (demux->segment_event) = gst_object_ref (demux);
> > > 
> > > Setting the src doesn't make much sense at all, the pad will be set as src
> > > later
> > 
> > Then we can simply remove it? Instead of moving it down here? I just moved it
> > as it was in there before and cause the crash.
> 
> How did you get a crash here? How could gst_event_new_segment() return NULL?

This was simply reproduced with an endless loop of stream stop/start events on
the same pipeline. I will try to revert the patch and see if the issue appears
again then later today. It might have been triggered by some other error, which
might fixed in the meantime. There were some memory corruptions, etc.

I will try to post an update on this in the afternoon.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.