[Bug 674865] directsoundsink: add support for ac3 over spdif

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=674865
  GStreamer | gst-plugins-good | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212868|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-04-26 11:49:11 UTC ---
Review of attachment 212868:
 --> (https://bugzilla.gnome.org/review?bug=674865&attachment=212868)

Looks good in general :) Does directsound also support DTS/DCA or MP3 or
something else? Can be added the same way with the payloaders in the audio
library

::: sys/directsound/gstdirectsoundsink.c
@@ +453,3 @@
+      gst_structure_get_boolean (st, "parsed", &parsed);
+      if ((!framed && !parsed) || gst_audio_iec61937_frame_size (&spec) <= 0)
+        goto done;

Might be good to actually check if the device supports AC3 too here

@@ +496,3 @@
+
+  type = GST_BASE_AUDIO_SINK (dsoundsink)->ringbuffer->spec.type;
+  return (type == GST_BUFTYPE_IEC958 || type == GST_BUFTYPE_AC3);

No IEC958 anymore

@@ +835,3 @@
         DXGetErrorString9 (hRes));
     caps =
         gst_caps_subtract (caps, gst_caps_new_simple ("audio/x-iec958",
NULL));

No IEC958 anymore

@@ +847,3 @@
   }
 #else
   caps = gst_caps_subtract (caps, gst_caps_new_simple ("audio/x-iec958",
NULL));

No IEC958 anymore

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.