[Bug 674865] directsoundsink: add support for ac3 over spdif

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=674865
  GStreamer | gst-plugins-good | 0.10.x

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2012-04-30 07:57:24 UTC ---
Review of attachment 212868:
 --> (https://bugzilla.gnome.org/review?bug=674865&attachment=212868)

::: sys/directsound/gstdirectsoundsink.c
@@ +429,3 @@
+  GstRingBufferSpec spec = { 0 };
+
+  pad_caps = gst_pad_get_caps_reffed (pad);

Does the getcaps function on the sinkpad only return what the device supports
if called in states >= READY?

@@ +432,3 @@
+  if (pad_caps) {
+    ret = gst_caps_can_intersect (pad_caps, caps);
+    gst_caps_unref (pad_caps);

If can_intersect() returns FALSE you should return that immediately without
doing the checks below.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.