[Bug 540891] [flac] Support embedded cuesheets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=540891
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220020|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge <slomo at circular-chaos.org> 2012-08-01 14:12:37 UTC ---
Review of attachment 220020:
 --> (https://bugzilla.gnome.org/review?bug=540891&attachment=220020)

::: ext/flac/gstflacenc.c
@@ +449,3 @@

+    if (flacenc->meta[3])
+      FLAC__metadata_object_delete (flacenc->meta[3]);

In the place where flacenc->meta is allocated you need to allocate one more
element now

@@ +597,3 @@
   gst_tag_list_foreach (copy, add_one_tag, flacenc);

+  toc = gst_toc_setter_get_toc (GST_TOC_SETTER (flacenc));

You need to unref this toc later when you don't use it anymore

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.