[Bug 680998] [wavenc] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680998
  GStreamer | gst-plugins-good | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220079|none                        |reviewed
             status|                            |

--- Comment #1 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-08-02 11:29:58 UTC ---
Review of attachment 220079:
 --> (https://bugzilla.gnome.org/review?bug=680998&attachment=220079)

::: gst/wavenc/gstwavenc.c
@@ +654,3 @@
+  list = gst_toc_entry_get_sub_entries (entry);
+  ncues = g_list_length (list);
+

just use g_new() if you set *all* fields

@@ +657,3 @@
+
+  memcpy (cue_chunk.chunk_id, "cue ", 4);
+  toc = wavenc->toc;

if possible please use sizeof(xx) instead of 24

@@ +664,3 @@
+    subentry = list->data;
+    if (!gst_toc_entry_is_sequence (subentry))
+  if (!gst_toc_entry_is_alternative (entry))

this leaks the memory pointer to by 'cues'

@@ +677,3 @@
+        gst_util_uint64_scale_round (start, wavenc->rate, GST_SECOND);
+    memcpy (cue_chunk.cue_points[i].data_chunk_id, "data", 4);
+

I think this is fine for now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.