[Bug 681327] [0.11] getters accessors for buffer pool and memory allocator in video decoder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681327
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220483|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-08-07 08:52:43 UTC ---
Review of attachment 220483:
 --> (https://bugzilla.gnome.org/review?bug=681327&attachment=220483)

Good idea in general, but for consistency the same should be done for the video
encoder base class, the audio decoder/encoder base classes, basetransform,
basesrc, basesink too. Could you prepare the same patches for them too? :)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3075,3 @@
+  g_return_val_if_fail (GST_IS_VIDEO_DECODER (decoder), NULL);
+
+  return decoder->priv->pool;

This should return a new reference to the pool

@@ +3089,3 @@
+  g_return_val_if_fail (GST_IS_VIDEO_DECODER (decoder), NULL);
+
+  return decoder->priv->allocator;

This should return a new reference to the allocator and the allocation
parameters, e.g.

void gst_video_decoder_get_allocator (GstVideoDecoder * decoder, GstAllocator
** allocator, GstAllocationParams * params)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.