[Bug 680998] [wavenc] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680998
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220490|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-08-07 16:16:06 UTC ---
Review of attachment 220490:
 --> (https://bugzilla.gnome.org/review?bug=680998&attachment=220490)

::: gst/wavenc/gstwavenc.c
@@ +677,3 @@
+  entry = list->data;
+
+  if (!gst_toc_entry_is_alternative (entry))

You should also allow a TOC with only a list of sequence-entries without a
top-level alternative.

@@ +681,3 @@
+
+  uid = gst_toc_entry_get_uid (entry);
+  if (g_strcmp0 ("cue", uid))

Don't do string comparisons with the uids. They're just meant to identify
entries, nothing else. What do you want to do here?

@@ +707,3 @@
+      gst_tag_list_get_string (tags, GST_TAG_TITLE, &title);
+    uid = gst_toc_entry_get_uid (subentry);
+    cues[i].id = (guint32) g_ascii_strtoll (uid, NULL, 0);

Don't do that. Check if the uid is a 32 bit integer and otherwise create random
numbers.

The uids can be of any format

@@ +714,3 @@
+    cues[i].chunk_start = 0;
+    cues[i].block_start = 0;
+    cues[i].sample_offset = 0;

This doesn't look correct, you should be able to calculate it

@@ +715,3 @@
+    cues[i].block_start = 0;
+    cues[i].sample_offset = 0;
+    if (title) {

You need to g_free() title when you're done with it

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.