[Bug 681327] [0.11] getters accessors for buffer pool and memory allocator in video decoder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681327
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220581|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2012-08-07 16:25:31 UTC ---
Review of attachment 220581:
 --> (https://bugzilla.gnome.org/review?bug=681327&attachment=220581)

::: libs/gst/base/gstbasesrc.c
@@ +3632,3 @@
+  g_return_val_if_fail (GST_IS_BASE_SRC (src), NULL);
+
+  return src->priv->pool;

You need to return a new reference to the pool here

@@ +3646,3 @@
+  g_return_val_if_fail (GST_IS_BASE_SRC (src), NULL);
+
+  return src->priv->allocator;

You need to return a new reference to the allocator here. And also the
GstAllocationParams, i.e.
gst_base_src_get_allocator (GstBaseSrc *src, GstAllocator **allocator,
GstAllocationParams *params)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.