[Bug 667838] jitterbuffer: don't produce lost-events for expired packets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=667838
  GStreamer | gst-plugins-good | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wim.taymans at gmail.com
         Resolution|                            |FIXED

--- Comment #10 from Wim Taymans <wim.taymans at gmail.com> 2012-12-13 11:35:30 UTC ---
commit 9c94f1187c1cdc13e2ea3bb019052c0887df0584
Author: Havard Graff <havard.graff at tandberg.com>
Date:   Fri Jan 13 01:11:31 2012 +0100

    jitterbuffer: bundle together late lost-events

    The scenario where you have a gap in a steady flow of packets of
    say 10 seconds (500 packets of with duration of 20ms), the jitterbuffer
    will idle up until it receives the first buffer after the gap, but will
    then go on to produce 499 lost-events, to "cover up" the gap.

    Now this is obviously wrong, since the last possible time for the earliest
    lost-events to be played out has obviously expired, but the fact that
    the jitterbuffer has a "length", represented with its own latency combined
    with the total latency downstream, allows for covering up at least some
    of this gap.

    So in the case of the "length" being 200ms, while having received packet
    500, the jitterbuffer should still create a timeout for packet 491, which
    will have its time expire at 10,02 seconds, specially since it might
    actually arrive in time! But obviously, waiting for packet 100, that had
    its time expire at 2 seconds, (remembering that the current time is 10)
    is useless...

    The patch will create one "big" lost-event for the first 490 packets,
    and then go on to create single ones if they can reach their
    playout deadline.

    See https://bugzilla.gnome.org/show_bug.cgi?id=667838

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.