[Bug 690152] New: [baseparse] invalid timestamps in pull mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690152
  GStreamer | gstreamer (core) | git

           Summary: [baseparse] invalid timestamps in pull mode
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: rawoul at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=231465)
 View: https://bugzilla.gnome.org/attachment.cgi?id=231465
 Review: https://bugzilla.gnome.org/review?bug=690152&attachment=231465

Attempt to fix timestamp issues

Commit 7518960829f5b32 makes baseparse output invalid timestamps in some cases.
For example a lot of buffers are dropped when playing this file: 

http://streams.videolan.org/samples/Matroska/120fps-mkv/%5bKTKJ%5d%5bstratos4_advance%5d%5b01%5d%5bbig5%5d%5bE72C0C1D%5d.mkv

Before this commit timestamps were also wrong when only DTS was set on input
buffers.

I have attached a few files:

 - a patch that attempts to correctly fix the issue (it needs review, I'm not
sure of all the implications of the change)

 - logs to demonstrate the timestamp issues. The logs show the timestamps after
parsing and decoding of an AVI/MPEG4 video. Before the faulty commit and my
patch, video and audio sync was off after some time in push mode. With my patch
it works fine in both pull and push modes, timestamps are the same.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.